Lots of small fixes to tests and ci stuff #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drone was trying to test 3.9 but tox would ignore it.
mikemrm
previously approved these changes
Feb 24, 2021
| @@ -4,7 +4,6 @@ clone: | |||
|
|
|||
| matrix: | |||
| PYTHON_VERSION: | |||
| - 3.5 | |||
There was a problem hiding this comment.
I believe the version of python osie is running still uses 3.5 :/
There was a problem hiding this comment.
wow we need to update those containers already
There was a problem hiding this comment.
put it back and added a comment
| @@ -11,11 +11,10 @@ matrix: | |||
|
|
|||
| pipeline: | |||
| fmt_and_lint: | |||
| image: python:3.8-alpine | |||
| image: nixos/nix:2.3.6 | |||
There was a problem hiding this comment.
i feel this over complicates the build process as well as gives the assumption that you need nix to run these tests.
There was a problem hiding this comment.
I can make clear that we don't require nix to run the tests? It does neatly pin the black/pylama(and co) versions which is nice for CI.
black was honoring the yapf ones, but we're probably better off with the generic `fmt` ones.
Helps debug tests where the output is not as expected.
stdlib, third party, finally local imports.
It only has one caller no need to complicate for imaginary situations.
Newer versions of click changed the error output from '-t' -> "-t". Doing it this way is compatible with older and newer versions.
Newer versions of click fail the test because the file passed to `-M` doesn't exist, so we need to ensure its created. Less patching/mocking is always a good thing imo too.
Black is the line length decider. You'd think I could just ignore E501 wouldn't you? Nope, this makes pycodestyle complain about some other things that it wasn't complaining about before :| ...
mmlb
force-pushed
the
bunch-o-ci-and-test-chores
branch
from
c56448c to
1479e81
Compare
mikemrm
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.