Fix Ubuntu etc/network/interfaces ordering #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 19, 2021 10:50
It seems that placing the individual ifaces below the bond creates a situation where `systemctl restart networking` fails. Ordering with said interfacs above the bond results in success.
dustinmiller
force-pushed
the
fix-debian-eni-ordering
branch
from
caaae0c to
9706e0f
Compare
mikemrm
approved these changes
Apr 20, 2021
mergify bot
added a commit
to tinkerbell/osie
that referenced
this pull request
Apr 20, 2021
## Description This reorders the /etc/network/interfaces file we generate for Ubunutu so that the ifaces are above the bond in the ordering, which allows for a successful `systemctl restart networking` packethost/packet-networking#35 ## Why is this needed Much better experience Fixes: ENG-14736 ## How Has This Been Tested? Looks good on Ubuntu 16/18/20 via custom OSIE provisions ## How are existing users impacted? What migration steps/scripts do we need? No break, only fix 🤞
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that placing the individual ifaces below the bond creates a
situation where
systemctl restart networkingfails. Ordering with saidinterfacs above the bond results in success.