Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpine support #45

Merged
merged 9 commits into from
Apr 20, 2022
Merged

Add alpine support #45

merged 9 commits into from
Apr 20, 2022

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Apr 13, 2022

This adds support for configuring networking on Alpine.

mikemrm added 3 commits April 13, 2022 19:29
lsb_release may generate n/a if it's unable to detect the distro or version.
This ignores those values and falls back to using the metadata data.
@mikemrm mikemrm force-pushed the add-alpine branch 3 times, most recently from dceda0f to 73e6abc Compare April 20, 2022 19:27
mikemrm added 6 commits April 20, 2022 19:30
Alpine uses mdev which currently generates the interface names eth*
Discovered interfaces could come from a udev enabled system resulting in
names like enp* which is not typically seen in Alpine.

Typically metadata also uses the eth* naming scheme, so for mdev we'll
switch to using the metadata names for an interface rather than the
discovered name.
@mikemrm mikemrm marked this pull request as ready for review April 20, 2022 19:39
@mikemrm mikemrm requested a review from dustinmiller April 20, 2022 19:39
"""

mactab = """\
# This file was automatically generated by the equinix metal installation environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we get this as Equinix Metal instead, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fixed this in a later commit

Copy link
Contributor

@dustinmiller dustinmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikemrm mikemrm merged commit f3b4f4b into master Apr 20, 2022
@mikemrm mikemrm deleted the add-alpine branch April 20, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants