Cleanups and some deletions #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't available for the actions to install anymore.
mmlb
force-pushed
the
cleanups-and-some-deletions
branch
2 times, most recently
from
d7e3dc9 to
03b80c1
Compare
mmlb
force-pushed
the
cleanups-and-some-deletions
branch
4 times, most recently
from
058b113 to
306f1cd
Compare
mmlb
force-pushed
the
cleanups-and-some-deletions
branch
3 times, most recently
from
f378249 to
71a170c
Compare
This way we only need to update one line in gha config. Also drops the dependency on format&lint since python tests don't actually depend on them.
Probably a copy/paste that was not updated.
This way the spacing is easier to manage and it also just reads better.
This is a minor refactor that I think makes things much easier to grok and
thus worth it. dns-nameserver goes up with the ip config stuff instead after
bond config. All the bond config stuff a grouped together w/o spaces. I also
tweaked the templates so that new lines are part of {% if %} blocks so we
don't have to deal with arbritary empty lines in the tests. This makes the
source templates a little busier because they don't have the empty lines
between the {% if %} blocks but I think its worth it since it makes writing
tests easier.
mmlb
force-pushed
the
cleanups-and-some-deletions
branch
from
71a170c to
03b80c1
Compare
dustinmiller
approved these changes
Jan 4, 2023
|
:toot: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of love in this PR, some via a broom some via axe!