Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOAPPFD0-173] Add A11Y related props to the LoadingSpinner #103

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[IOAPPFD0-173] Add A11Y related props to the LoadingSpinner #103

merged 2 commits into from
Oct 13, 2023

Conversation

dmnplb
Copy link
Collaborator

@dmnplb dmnplb commented Oct 13, 2023

Short description

This PR adds some new A11Y related props to the LoadingSpinner. It also slightly refactor the component removing the stroke prop.

List of changes proposed in this pull request

  • Add optional accessibilityHint and accessibilityLabel props
  • Remove stroke prop, replacing it with a strokeMap based on size of the loading spinner

How to test

N/A

@dmnplb dmnplb added the a11y label Oct 13, 2023
@dmnplb dmnplb requested review from a team as code owners October 13, 2023 08:01
@dmnplb dmnplb mentioned this pull request Oct 13, 2023
Merged
@dmnplb dmnplb merged commit 6803ab8 into main Oct 13, 2023
2 checks passed
@dmnplb dmnplb deleted the IOAPPFD0-173-loading-spinner-refinement branch October 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

Assignees
No one assigned
Labels
a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @CrisTofani