Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPFD0-174] Add the new LoadingIndicator component #5111

Merged
merged 8 commits into from
Oct 13, 2023

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 13, 2023

Short description

This PR adds the new LoadingIndicator component, a component that contains a predefined set of values that are applied to the LoadingSpinner component. This component is intended to be an alternative to the current ActivityIndicator component.

List of changes proposed in this pull request

  • Update io-app-design-system to 1.13.1
  • Add the new LoadingIndicator component
  • Add different colors based on the experimental DS value
  • Add the predefined a11y related props

Preview

loading-indicator-ds.mp4

Related PR:

How to test

Go to the Profile → Design System → Loaders

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Oct 13, 2023
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 08:22 — with GitHub Actions Inactive
@dmnplb dmnplb marked this pull request as ready for review October 13, 2023 08:22
@dmnplb dmnplb requested a review from a team as a code owner October 13, 2023 08:22
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPFD0-174] Add the new LoadingIndicator component chore: [IOAPPFD0-174] Add the new LoadingIndicator component Oct 13, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 13, 2023

Affected stories

Generated by 🚫 dangerJS against 708f7d2

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #5111 (7d5c57a) into master (3606446) will decrease coverage by 0.01%.
The diff coverage is 30.76%.

❗ Current head 7d5c57a differs from pull request most recent head 708f7d2. Consider uploading reports for the commit 708f7d2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
- Coverage   47.88%   47.87%   -0.01%     
==========================================
  Files        1524     1525       +1     
  Lines       31454    31467      +13     
  Branches     7797     7802       +5     
==========================================
+ Hits        15062    15066       +4     
- Misses      16344    16353       +9     
  Partials       48       48              
Files Coverage Δ
ts/features/design-system/core/DSLoaders.tsx 50.00% <60.00%> (+16.66%) ⬆️
ts/components/ui/LoadingIndicator.tsx 12.50% <12.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3606446...708f7d2. Read the comment docs.

@dmnplb dmnplb temporarily deployed to dev October 13, 2023 09:07 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 10:09 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 12:27 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 12:33 — with GitHub Actions Inactive
@dmnplb dmnplb temporarily deployed to dev October 13, 2023 14:30 — with GitHub Actions Inactive
@CrisTofani CrisTofani temporarily deployed to dev October 13, 2023 15:21 — with GitHub Actions Inactive
@dmnplb dmnplb merged commit af80467 into master Oct 13, 2023
5 checks passed
@dmnplb dmnplb deleted the IOAPPFD0-174-loading-indicator branch October 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants