Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rework TabItem component color map #236

Merged
merged 5 commits into from
Apr 8, 2024
Merged

chore: Rework TabItem component color map #236

merged 5 commits into from
Apr 8, 2024

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Apr 5, 2024 •
edited
Loading

Short description

This PR revamps the color map on TabItem component

List of changes proposed in this pull request

  • Add new colors in map
  • Handle legacy colors

How to test

Check TabItem component on Tab Navigation screen on example app

@CrisTofani CrisTofani requested review from dmnplb and a team as code owners April 5, 2024 08:48
@CrisTofani CrisTofani mentioned this pull request Apr 5, 2024
Merged
dmnplb
dmnplb approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@dmnplb dmnplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved some states with the commit 7246240
Check it out and let me know if it makes sense 💪🏻

@CrisTofani
Copy link
Contributor Author

Improved some states with the commit 7246240 Check it out and let me know if it makes sense 💪🏻

@dmnplb perfect! We can merge!

@CrisTofani CrisTofani merged commit 95be291 into main Apr 8, 2024
6 checks passed
@CrisTofani CrisTofani deleted the chore-tab-navigation-component-refinement branch April 8, 2024 14:54
@CrisTofani CrisTofani mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb dmnplb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisTofani @dmnplb