Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TabNavigation component #242

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Update TabNavigation component #242

merged 8 commits into from
Apr 9, 2024

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Apr 8, 2024 •
edited
Loading

Short description

This PR updates the TabNavigation component removing the internal state for selected item

List of changes proposed in this pull request

  • Removed internal state for selected item
  • Updated component page in example app

@mastro993 mastro993 requested review from dmnplb and a team as code owners April 8, 2024 16:53
@CrisTofani
Copy link
Contributor

CrisTofani commented Apr 8, 2024 •
edited
Loading

Is this a duplicate PR of the already merged #236 ?

@mastro993 mastro993 closed this Apr 9, 2024
@mastro993 mastro993 reopened this Apr 9, 2024
@mastro993
Copy link
Contributor Author

mastro993 commented Apr 9, 2024 •
edited
Loading

Is this a duplicate PR of the already merged #236 ?

Partly yes, but there is still a problem with the internal TabNavigation state which should be removed

CrisTofani
CrisTofani approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit 8bef08e into main Apr 9, 2024
6 checks passed
@mastro993 mastro993 deleted the update-tabs-component branch April 9, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

@dmnplb dmnplb Awaiting requested review from dmnplb dmnplb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mastro993 @CrisTofani