[IOAPPX-443] Restore a11y props in the Banner component
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastro993
approved these changes
Nov 30, 2024
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
Dec 16, 2024
…Fix overflow text on cards + Extend dark mode support (#6473) > [!caution] > This PR depends on: > * #6422 > * pagopa/io-app-design-system#364 ## Short description This PR disables the dark mode appearance of text placed on light backgrounds, such as wallet cards. It also extends dark mode support to other DS components. ## List of changes proposed in this pull request - Update `io-app-design-system` to `4.2.0` - Extend dark mode support to `Alert`, `Banner` and `FeatureInfo` - Fix `CgnCard` and `PaymentCard` dark mode appearance - Force light mode on `Tag` in the `ItwCredentialCard` component - Enable larger and bolder text on the `ItwCredentialCard` component by replacing the native `Text` with properly configured `IOText` (cc @mastro993) - Remove preview version of `ItwCredentialCard` - Fix `CgnCard` and `PaymentCard` expired tag overflow when larger text is set - Remove unused `PaymentCardBig` component to reduce the likelihood of misunderstandings ### Preview A look at an _unlikely_ edge case <img width="300" src="https://github.com/user-attachments/assets/a3a8d013-5fe6-4fde-ad10-886a7b419ee8" /> Dark mode support extended to the `Banner` component <img width="300" src="https://github.com/user-attachments/assets/5f528249-9045-4d2f-8183-aa0b4a4deab5" /> ## How to test Increase the text size to extreme levels and check all the cards in the DS section --------- Co-authored-by: Emanuele Dall'Ara <71103219+LeleDallas@users.noreply.github.com> Co-authored-by: Federico Mastrini <federicomastrini93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR restores
a11yprops in theBannercomponent, erroneously removed with the PR #344