chore(Cross): [IOAPPX-442] Fix dark mode text on light backgrounds + Fix overflow text on cards + Extend dark mode support #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
deleted the
IOAPPX-442-fix-dark-mode-text-on-light-backgrounds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This PR depends on:
io-app-design-systemto4.0.1#6422a11yprops in theBannercomponent io-app-design-system#364Short description
This PR disables the dark mode appearance of text placed on light backgrounds, such as wallet cards. It also extends dark mode support to other DS components.
List of changes proposed in this pull request
io-app-design-systemto4.2.0Alert,BannerandFeatureInfoCgnCardandPaymentCarddark mode appearanceTagin theItwCredentialCardcomponentItwCredentialCardcomponent by replacing the nativeTextwith properly configuredIOText(cc @mastro993)ItwCredentialCardCgnCardandPaymentCardexpired tag overflow when larger text is setPaymentCardBigcomponent to reduce the likelihood of misunderstandingsPreview
A look at an unlikely edge case
Dark mode support extended to the
BannercomponentHow to test
Increase the text size to extreme levels and check all the cards in the DS section