-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-356] Add divider to first level sections when the user scrolls + Add useHeaderFirstLevel
hook
#6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
New visual language and reduction of previous UI clutter
label
Jul 26, 2024
pagopa-github-bot
changed the title
[IOAPPX-356] Add divider to first level sections when the user scrolls
chore(Cross): [IOAPPX-356] Add divider to first level sections when the user scrolls
Jul 26, 2024
Affected stories
|
CrisTofani
requested changes
Dec 11, 2024
mastro993
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything looks as expected
CrisTofani
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This change applies only to the Wallet, Services and Payments sections.
Short description
This PR adds the new divider transition to first level sections when the user scrolls. To get this behaviour, we need to define
HeaderFirstLevelProps
directly in the main screen throughuseLayoutEffect
where the mainScrollView
orFlatList
is placed.To avoid code duplication, there's a new
useHeaderFirstLevelActionPropHelp
's hook that returns a FAQ configuration object based on the provided route.List of changes proposed in this pull request
HeaderFirstLevel
using theuseScrollViewOffset
hook fromreanimated
Add the new optionalUpdate: removed from the PRendBlock
prop toHeaderFirstLevel
to render custom block (see the Services screen for a demonstrationHeaderFirstLevelHandler
into relative first level sectionsHeaderFirstLevelHandler
completelyHeaderFirstLevel
:useHeaderFirstLevelActionPropHelp
to get the props related to the Help sectionuseHeaderFirstLevelActionPropSettings
to get the props related to the Settings sectionuseHeaderFirstLevel
to set theHeaderFirstLevel
by usinguseLayoutEffect
withreact-navigation
HeaderFirstLevel
by making two actions mandatory andthirdAction
optionalHeaderFirstLevel
with the latest changes fromio-app-design-system
Preview
Important
The divider is set with
hairlineWidth
, so it's very thin. If you want to see the change, download the following videos and play them at full resolutionwallet-divider-new.mp4
services-divider.mp4
payment-divider.mp4
How to test
Go to the above sections and check that everything is correct. Also check the relative flow of the Assistance in each first level section.