[IOAPPX-365] Add enableDiscreteTransition to HeaderSecondLevel to allow transition even if triggerOffset is not set
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
approved these changes
Aug 27, 2024
dmnplb
deleted the
IOAPPX-365-add-discrete-transition-header-second-level
branch
dmnplb
added a commit
to pagopa/io-app
that referenced
this pull request
Sep 11, 2024
… to the `useHeaderSecondLevel` hook (#6170) ## Short description This PR adds support for `enableDiscreteTransition` to the `useHeaderSecondLevel` hook. If you want to learn more about this prop, please refer to the following PR: * pagopa/io-app-design-system#323 ## List of changes proposed in this pull request - Add support for the new `enableDiscreteTransition` prop - Refactor the code to improve readability - Remove `canGoBack` declarations when they are set to true (it is already `true` by default) ## How to test Run all the tests provided by default --------- Co-authored-by: Federico Mastrini <federicomastrini93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the new
enableDiscreteTransitionoption toHeaderSecondLevelto allow an animated transition whentriggerOffsetis not set, or in some specific cases where there is a custom background and the default transition looks bad. The new transition differs from the previous one in that it's always triggered when the user scrolls down, even by one pixel. In the default transition you need to set a custom height along with a propersnapToOffsetsarray.List of changes proposed in this pull request
enableDiscreteTransitionboolean prop along with theanimatedRefmandatory propexampleapp for demo purposesPreview
default-transition.mp4
discrete-transition.mp4
Related PR
useHeaderFirstLevelhook io-app#6054How to test