chore(Cross): [IOAPPX-369] Add support for enableDiscreteTransition to the useHeaderSecondLevel hook
#6170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
Design System
…-header-2ndlevel-hook
pagopa-github-bot
changed the title
enableDiscreteTransition to the useHeaderSecondLevel hookenableDiscreteTransition to the useHeaderSecondLevel hook
Affected stories
|
dmnplb
removed
the
code review needed 💻📱
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6170 +/- ##
==========================================
- Coverage 48.42% 47.77% -0.66%
==========================================
Files 1488 1746 +258
Lines 31617 35095 +3478
Branches 7669 8382 +713
==========================================
+ Hits 15311 16767 +1456
- Misses 16238 18270 +2032
+ Partials 68 58 -10
... and 1230 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…-header-2ndlevel-hook
dmnplb
deleted the
IOAPPX-369-add-discrete-transition-support-header-2ndlevel-hook
branch
dmnplb
added a commit
that referenced
this pull request
Sep 23, 2024
…rdScreenComponent` (#6171) > [!note] > This PR depends on: > * #6170 ## Short description This PR enables discrete transition in the `BonusCardScreenComponent` thanks to the new updated `useHeaderSecondLevel` hook. ## List of changes proposed in this pull request - Add support for `enableDiscreteTransition` to the `BonusCardScreenComponent` - Partially refactor `CgnDetailScreen` to improve compatibility with the `IOScrollView` (cc @freddi301 @Hantex9) - Add dark mode support to the `BonusCardShape` component - Add some documentation to the `IOScrollView` component ### Preview https://github.com/user-attachments/assets/4b03a3da-1444-4d25-bbc2-31eeedd6994e ## How to test 1. Locally launch the app 2. Go to the **DS → Bonus Card Screen** or go the **CGN** main screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds support for
enableDiscreteTransitionto theuseHeaderSecondLevelhook. If you want to learn more about this prop, please refer to the following PR:enableDiscreteTransitiontoHeaderSecondLevelto allow transition even iftriggerOffsetis not set io-app-design-system#323List of changes proposed in this pull request
enableDiscreteTransitionpropcanGoBackdeclarations when they are set to true (it is alreadytrueby default)How to test
Run all the tests provided by default