Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-584] SEND routing to F24 download and retry management #1066

Merged
merged 9 commits into from
Oct 26, 2023
Merged

[#IOCOM-584] SEND routing to F24 download and retry management #1066

merged 9 commits into from
Oct 26, 2023

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Added new types and routing for SEND F24 download.
Added headers to response.
Fixed some code.

Motivation and Context

SEND exposes the download of F24 on a different endpoint than attachments. We need to silently reroute this Remote Content call to keep it on one path.

How Has This Been Tested?

build
test
lint

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@michaeldisaro michaeldisaro requested a review from a team as a code owner October 17, 2023 16:37
@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-584

Garma00
Garma00 reviewed Oct 18, 2023
View reviewed changes
openapi/consumed/api-piattaforma-notifiche.yaml
description: Returns the AppIo user activation status
- AppIO-PN-Payments
summary: Download allegato per pagamento
operationId: getReceivedNotificationAttachment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may we use something with "payment" ?

@adelloste adelloste mentioned this pull request Oct 20, 2023
Merged
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.5% 15.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@michaeldisaro
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@michaeldisaro michaeldisaro merged commit 92bb7ea into master Oct 26, 2023
3 of 4 checks passed
@michaeldisaro michaeldisaro deleted the iocom-584 branch October 26, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garma00 Garma00 Garma00 approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

@drmarro drmarro Awaiting requested review from drmarro drmarro is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldisaro @Garma00