[#174877080] Upgrade to italia-utils 5.x #711

balanza · 2020-09-18T15:21:33Z

This PR upgrades italia-utils to its latest major version. The following changes are included:

Solved field name issues due to italia-utils's breaking changes
Change profile.date_of_birth type from string to Date (hhttps://github.com/pagopa/io-backend/compare/174877080-upgrade-io-utils?expand=1#diff-246173bb5ff1765d2dccdb32a3d93262R31ere)
Use io-functions-api generated client
Use io-functions-bonus generated client
Use pagopa-proxy generated client

codecov-commenter · 2020-09-18T15:21:40Z

Codecov Report

Merging #711 into master will increase coverage by 2.02%.
The diff coverage is 80.71%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   78.99%   81.02%   +2.02%     
==========================================
  Files          65       68       +3     
  Lines        2119     2219     +100     
  Branches      342      373      +31     
==========================================
+ Hits         1674     1798     +124     
+ Misses        433      408      -25     
- Partials       12       13       +1

Impacted Files	Coverage Δ
src/server.ts	`0.00% <0.00%> (ø)`
src/services/bonusService.ts	`75.00% <ø> (ø)`
src/services/pagoPAProxyService.ts	`94.44% <ø> (ø)`
src/services/userDataProcessingService.ts	`96.77% <ø> (ø)`
src/utils/responses.ts	`91.30% <ø> (ø)`
src/strategies/bearerBPDTokenStrategy.ts	`41.17% <41.17%> (ø)`
src/strategies/bearerMyPortalTokenStrategy.ts	`41.17% <41.17%> (ø)`
src/config.ts	`79.43% <45.45%> (-2.88%)`	⬇️
src/types/commons.ts	`80.00% <50.00%> (-20.00%)`	⬇️
src/clients/api.ts	`71.42% <75.00%> (+24.62%)`	⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e09751...5e081c3. Read the comment docs.

pagopa-github-bot · 2020-09-18T15:22:37Z

Affected stories

🌟 #174877080: Come DEV voglio pote utilizzare i client delle API generati sul backend dell'app

Generated by 🚫 dangerJS

balanza · 2020-09-18T15:23:41Z

src/clients/api.ts

+/* function SubscriptionKeyHeaderProducer<P>(
  token: string
 ): RequestHeaderProducer<P, "X-Functions-Key" | "Ocp-Apim-Subscription-Key"> {
  return () => ({
    "Ocp-Apim-Subscription-Key": token,
    "X-Functions-Key": token
  });
-}
+} */


@gunzip @francescopersico please take a look here:
the former code used to pass token to both X-Functions-Key andOcp-Apim-Subscription-Key header. With the latest implementation, only the latter is valued. Which is the correct configuration?

we must update the specs on io-functions-app to take only X-Functions-Key

pagopa/io-functions-app#106

balanza · 2020-09-18T15:24:42Z

src/types/profile.ts

@@ -28,7 +28,7 @@ export const toInitializedProfile = (
  blocked_inbox_or_channels: profile.blocked_inbox_or_channels,
  date_of_birth:
    user.date_of_birth !== undefined
-      ? formatDate(user.date_of_birth)
+      ? new Date(formatDate(user.date_of_birth))


@gunzip please double-check this change as we need to be sure that the type-change is invariant for the API behaviour.

can you try to test this locally using io-mock?

basically the output format now changes from 1991-12-12 to 1991-12-12T00:00:00.000Z. The client app ignores this value anyway.

codecov-io · 2020-10-07T09:07:15Z

Codecov Report

Merging #711 into master will increase coverage by 1.26%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   79.67%   80.94%   +1.26%     
==========================================
  Files          68       68              
  Lines        2298     2225      -73     
  Branches      370      370              
==========================================
- Hits         1831     1801      -30     
+ Misses        454      411      -43     
  Partials       13       13

Impacted Files	Coverage Δ
src/services/bonusService.ts	`75.00% <ø> (ø)`
src/services/pagoPAProxyService.ts	`94.44% <ø> (ø)`
src/services/userDataProcessingService.ts	`96.77% <ø> (ø)`
src/clients/api.ts	`71.42% <75.00%> (+24.62%)`	⬆️
src/clients/bonus.ts	`85.71% <75.00%> (+31.86%)`	⬆️
src/clients/pagopa.ts	`100.00% <100.00%> (+47.36%)`	⬆️
src/services/messagesService.ts	`81.66% <100.00%> (ø)`
src/services/profileService.ts	`96.42% <100.00%> (ø)`
src/types/profile.ts	`91.66% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8028b3d...b2e7987. Read the comment docs.

…a/io-backend into 174877080-upgrade-io-utils

gunzip · 2020-10-20T14:51:08Z

src/clients/api.ts

-} {
-  const options = {
+): Client<"SubscriptionKey"> {
+  return createClient<"SubscriptionKey">({


this must be x-functions-key (Ocp-Apim-Subscription-Key is unused)

It actually is. The referenced api spec is

SubscriptionKey: type: apiKey name: X-Functions-Key in: header

Under the hood, the generated client does the following:

headers: ({ SubscriptionKey }: { SubscriptionKey: string }) => ({ "X-Functions-Key": `Bearer ${SubscriptionKey}` }),

that's right, not easy to grasp from the code here :-) (maybe we could add a comment?)

BurnedMarshal · 2020-10-27T09:22:59Z

src/clients/pagopa.ts

-  const options = {
+): Client {
+  return createClient({
+    basePath: "",


Does this param override the spec defined base path?

yes, generated client use the value from the spec as default. This basically tells the client to ignore such value.
Please note that the full host+basepath has been passed by the constructor, which is not touched by this PR

io-backend/src/config.ts

Line 306 in 33c172e

export const PAGOPA_CLIENT = new PagoPAClientFactory(

BurnedMarshal

lgtm

balanza added 3 commits September 18, 2020 12:10

upgraded io-utils and solve breaking changes

0027732

generate client for app api

7f8a935

fix test

b801cf8

balanza requested review from gunzip, BurnedMarshal, francescopersico and AleDore September 18, 2020 15:21

balanza self-assigned this Sep 18, 2020

balanza commented Sep 18, 2020

View reviewed changes

balanza mentioned this pull request Sep 18, 2020

[#174877080] Change subscription key header pagopa/io-functions-app#106

Merged

balanza added 6 commits September 21, 2020 13:16

fixes

d97ea72

implement bonus client

bd570ea

implement pagopa proxy client

614692c

fix lint

17de3fe

Merge branch 'master' into 174877080-upgrade-io-utils

5e081c3

Merge branch 'master' into 174877080-upgrade-io-utils

704b5e3

balanza added 2 commits October 20, 2020 14:49

Merge branch 'master' into 174877080-upgrade-io-utils

260e6b4

Merge branch '174877080-upgrade-io-utils' of https://github.com/pagop…

1465d94

…a/io-backend into 174877080-upgrade-io-utils

balanza marked this pull request as ready for review October 20, 2020 13:09

gunzip requested changes Oct 20, 2020

View reviewed changes

balanza added 2 commits October 22, 2020 11:12

Merge branch 'master' into 174877080-upgrade-io-utils

d06ce61

comments

b2e7987

balanza requested a review from gunzip October 27, 2020 09:07

BurnedMarshal reviewed Oct 27, 2020

View reviewed changes

gunzip approved these changes Oct 27, 2020

View reviewed changes

balanza merged commit fa0147d into master Oct 27, 2020

balanza deleted the 174877080-upgrade-io-utils branch October 27, 2020 13:18

balanza mentioned this pull request Oct 27, 2020

[#174877080] Upgrade io utils to v6 #723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#174877080] Upgrade to italia-utils 5.x #711

[#174877080] Upgrade to italia-utils 5.x #711

balanza commented Sep 18, 2020 •

edited

Loading

codecov-commenter commented Sep 18, 2020 •

edited

Loading

pagopa-github-bot commented Sep 18, 2020 •

edited

Loading

balanza Sep 18, 2020

gunzip Sep 18, 2020

balanza Sep 18, 2020

balanza Sep 18, 2020

gunzip Sep 18, 2020

balanza Sep 21, 2020

codecov-io commented Oct 7, 2020 •

edited

Loading

gunzip Oct 20, 2020

balanza Oct 22, 2020

gunzip Oct 22, 2020

balanza Oct 22, 2020

BurnedMarshal Oct 27, 2020

balanza Oct 27, 2020

BurnedMarshal left a comment

[#174877080] Upgrade to italia-utils 5.x #711

[#174877080] Upgrade to italia-utils 5.x #711

Conversation

balanza commented Sep 18, 2020 • edited Loading

codecov-commenter commented Sep 18, 2020 • edited Loading

Codecov Report

pagopa-github-bot commented Sep 18, 2020 • edited Loading

Affected stories

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 7, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BurnedMarshal left a comment

Choose a reason for hiding this comment

balanza commented Sep 18, 2020 •

edited

Loading

codecov-commenter commented Sep 18, 2020 •

edited

Loading

pagopa-github-bot commented Sep 18, 2020 •

edited

Loading

codecov-io commented Oct 7, 2020 •

edited

Loading