[#174877080] Upgrade to italia-utils 5.x #711
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,239 +1,33 @@ | ||
| import nodeFetch from "node-fetch"; | ||
| import { Client, createClient } from "../../generated/io-api/client"; | ||
|
|
||
| // we want to authenticate against the platform APIs with the APIM header key or | ||
| // the Azure Functions header key, so we send both headers | ||
| /* function SubscriptionKeyHeaderProducer<P>( | ||
| token: string | ||
| ): RequestHeaderProducer<P, "X-Functions-Key" | "Ocp-Apim-Subscription-Key"> { | ||
| return () => ({ | ||
| "Ocp-Apim-Subscription-Key": token, | ||
| "X-Functions-Key": token | ||
| }); | ||
| } */ | ||
|
|
||
| export function APIClient( | ||
| baseUrl: string, | ||
| token: string, | ||
| // tslint:disable-next-line:no-any | ||
| fetchApi: typeof fetch = (nodeFetch as any) as typeof fetch // TODO: customize fetch with timeout | ||
| ): Client<"SubscriptionKey"> { | ||
| return createClient<"SubscriptionKey">({ | ||
|
There was a problem hiding this comment. this must be x-functions-key (Ocp-Apim-Subscription-Key is unused) There was a problem hiding this comment. It actually is. The referenced api spec is SubscriptionKey:
type: apiKey
name: X-Functions-Key
in: headerUnder the hood, the generated client does the following: headers: ({ SubscriptionKey }: { SubscriptionKey: string }) => ({
"X-Functions-Key": `Bearer ${SubscriptionKey}`
}),There was a problem hiding this comment. that's right, not easy to grasp from the code here :-) (maybe we could add a comment?) |
||
| basePath: "", | ||
| baseUrl, | ||
| fetchApi, | ||
| withDefaults: op => params => | ||
| op({ | ||
| ...params, | ||
| SubscriptionKey: token | ||
| }) | ||
| }); | ||
| } | ||
|
|
||
| export type APIClient = typeof APIClient; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gunzip @francescopersico please take a look here:
the former code used to pass
tokento bothX-Functions-KeyandOcp-Apim-Subscription-Keyheader. With the latest implementation, only the latter is valued. Which is the correct configuration?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we must update the specs on io-functions-app to take only X-Functions-Key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pagopa/io-functions-app#106