[table] fix: set grid bleed >= numFrozenColumns (#5049)

Co-authored-by: Adi Dahiya <adahiya@palantir.com>
palantir · Feb 9, 2022 · 3a1b623 · 3a1b623 · blueprint-bot · Feb 9, 2022
1 parent a8d7453
commit 3a1b623
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/table/src/table.tsx b/packages/table/src/table.tsx
@@ -1081,9 +1081,12 @@ export class Table extends AbstractComponent2<TableProps, TableState, TableSnaps
 
     private validateGrid() {
         if (this.grid == null) {
-            const { defaultRowHeight, defaultColumnWidth } = this.props;
+            const { defaultRowHeight, defaultColumnWidth, numFrozenColumns } = this.props;
             const { rowHeights, columnWidths } = this.state;
-            this.grid = new Grid(rowHeights, columnWidths, Grid.DEFAULT_BLEED, defaultRowHeight, defaultColumnWidth);
+
+            // gridBleed should always be >= numFrozenColumns since columnIndexStart adds numFrozenColumns
+            const gridBleed = Math.max(Grid.DEFAULT_BLEED, numFrozenColumns);
+            this.grid = new Grid(rowHeights, columnWidths, gridBleed, defaultRowHeight, defaultColumnWidth);
             this.invokeOnVisibleCellsChangeCallback(this.state.viewportRect);
             this.hotkeysImpl.setGrid(this.grid);
         }

diff --git a/packages/table/src/table2.tsx b/packages/table/src/table2.tsx
@@ -927,9 +927,12 @@ export class Table2 extends AbstractComponent2<TableProps, TableState, TableSnap
 
     private validateGrid() {
         if (this.grid == null) {
-            const { defaultRowHeight, defaultColumnWidth } = this.props;
+            const { defaultRowHeight, defaultColumnWidth, numFrozenColumns } = this.props;
             const { rowHeights, columnWidths } = this.state;
-            this.grid = new Grid(rowHeights, columnWidths, Grid.DEFAULT_BLEED, defaultRowHeight, defaultColumnWidth);
+
+            // gridBleed should always be >= numFrozenColumns since columnIndexStart adds numFrozenColumns
+            const gridBleed = Math.max(Grid.DEFAULT_BLEED, numFrozenColumns);
+            this.grid = new Grid(rowHeights, columnWidths, gridBleed, defaultRowHeight, defaultColumnWidth);
             this.invokeOnVisibleCellsChangeCallback(this.state.viewportRect);
             this.hotkeysImpl.setGrid(this.grid);
         }