Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] fix: set grid bleed >= numFrozenColumns #5049

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

mattskrobola
Copy link
Contributor

Fixes #5048

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Set the grid's bleed to the max of the default and numFrozenColumns

Reviewers should focus on:

Screenshot

Before:
frozencolScroll

After:

after

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @mattskrobola! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works in the docs app, after merging develop:
2022-02-09 10 13 19

@adidahiya adidahiya changed the title set Table grid bleed >= numFrozenColumns [table] fix: set grid bleed >= numFrozenColumns Feb 9, 2022
@adidahiya adidahiya merged commit 3a1b623 into palantir:develop Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large columns stop rendering when scrolling horizontally and number of frozen columns > 3
3 participants