Revert: Fix border overlap between Buttons in outlined ButtonGroup (#…

…7002)
palantir · Sep 30, 2024 · 7f83b30 · 7f83b30 · svc-palantir-github · Sep 30, 2024
1 parent 3f4a894
commit 7f83b30
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 25 deletions.
diff --git a/packages/core/src/components/button/_button-group.scss b/packages/core/src/components/button/_button-group.scss
@@ -142,26 +142,17 @@ Styleguide button-group
   }
 
   &.#{$ns}-outlined {
-    > .#{$ns}-popover-target > .#{$ns}-button,
     > .#{$ns}-button {
       @include pt-button-outlined();
     }
 
     &:not(.#{$ns}-vertical) {
-      > .#{$ns}-popover-target:not(:last-child) > .#{$ns}-button,
       > .#{$ns}-button:not(:last-child) {
         border-right: none;
       }
     }
   }
 
-  &:not(.#{$ns}-vertical) {
-    > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button.#{$ns}-outlined,
-    > .#{$ns}-button.#{$ns}-outlined:not(:last-child) {
-      border-right: none;
-    }
-  }
-
   .#{$ns}-popover-wrapper,
   .#{$ns}-popover-target {
     display: flex;
@@ -261,16 +252,10 @@ Styleguide button-group
     }
 
     &.#{$ns}-outlined {
-      > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button,
       > .#{$ns}-button:not(:last-child) {
         border-bottom: none;
       }
     }
-
-    > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button.#{$ns}-outlined,
-    > .#{$ns}-button.#{$ns}-outlined:not(:last-child) {
-      border-bottom: none;
-    }
   }
 
   &.#{$ns}-align-left .#{$ns}-button {

diff --git a/packages/core/src/components/popover/_popover-in-button-group.scss b/packages/core/src/components/popover/_popover-in-button-group.scss
@@ -15,12 +15,7 @@
     > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button {
       border-bottom-right-radius: 0;
       border-top-right-radius: 0;
-    }
-
-    &:not(.#{$ns}-outlined) {
-      > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button:not(.#{$ns}-outlined) {
-        margin-right: -$button-border-width;
-      }
+      margin-right: -$button-border-width;
     }
   }
 
@@ -39,10 +34,8 @@
         border-radius: 0 0 $pt-border-radius $pt-border-radius;
       }
 
-      &:not(.#{$ns}-outlined) {
-        > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button:not(.#{$ns}-outlined) {
-          margin-bottom: -$button-border-width;
-        }
+      > .#{$ns}-popover-target:not(:last-child) .#{$ns}-button {
+        margin-bottom: -$button-border-width;
       }
     }
   }