Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Fix border overlap between Buttons in outlined ButtonGroup #7002

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Sep 27, 2024

This reverts the changes added in #6966 (while retaining additions to the docs). The removal of borders between Buttons in ButtonGroup had the unintentional consequence of regressing styles for ButtonGroups that contain mixed intents or mixed types of buttons.

@changelog-app
Copy link

changelog-app bot commented Sep 27, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Revert: Fix border overlap between Buttons in outlined ButtonGroup

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Keep changes to ButtonGroup docs example

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-27 at 4 08 31 PM

leaving example of observed undesired behavior

thanks for the fix!

@ggdouglas ggdouglas merged commit 7f83b30 into develop Sep 30, 2024
12 of 14 checks passed
@ggdouglas ggdouglas deleted the revert-6966-gdouglas/fix-button-group-outlined branch September 30, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants