[eslint-plugin] fix(classes-constants): ignore imports/exports (#5076)

palantir · Jan 4, 2022 · 8403bf2 · 8403bf2 · blueprint-bot · Jan 4, 2022
1 parent e0dd35e
commit 8403bf2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/classes-constants.ts b/packages/eslint-plugin/src/rules/classes-constants.ts
@@ -52,6 +52,13 @@ export const classesConstantsRule = createRule<[], MessageIds>({
 });
 
 function create(context: RuleContext<MessageIds, []>, node: TSESTree.Literal | TSESTree.TemplateElement): void {
+    // We shouldn't lint on strings from imports/exports
+    if (
+        node.parent?.type === AST_NODE_TYPES.ImportDeclaration ||
+        node.parent?.type === AST_NODE_TYPES.ExportNamedDeclaration
+    ) {
+        return;
+    }
     const nodeValue = node.type === AST_NODE_TYPES.Literal ? node.raw : node.value.raw;
     const prefixMatches = getAllMatches(nodeValue);
     if (prefixMatches.length > 0) {

diff --git a/packages/eslint-plugin/test/classes-constants.test.ts b/packages/eslint-plugin/test/classes-constants.test.ts
@@ -162,5 +162,9 @@ ruleTester.run("classes-constants", classesConstantsRule, {
 
         // it should not touch icons as theyre handled by a different rule
         '<div className="pt-icon-folder-open" />',
+
+        // don't flag strings in export/import statements
+        'import { test } from "packagewithpt-thatshouldnterror";',
+        'export { test } from "packagewithpt-thatshouldnterror";',
     ],
 });