Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-plugin] fix(classes-constants): ignore imports/exports #5076

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

styu
Copy link
Contributor

@styu styu commented Dec 17, 2021

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

If you have an import from a package like this:

import { someFunction } from "packagewithpt-thaterrors";

The ESLInt rule will ask you to change that string to use a Blueprint class instead :)

This changes it so that import declarations/named exports are ignored

@blueprint-bot
Copy link

Don't flag imports/exports in Blueprint classes ESLint rule

Previews: documentation | landing | table | modern colors demo

@blueprint-bot
Copy link

undo whitepsace changes

Previews: documentation | landing | table | modern colors demo

@styu styu requested a review from adidahiya January 4, 2022 15:14
@adidahiya adidahiya changed the title Don't flag imports/exports in Blueprint classes ESLint rule [eslint-plugin] fix(classes-constants): ignore imports/exports Jan 4, 2022
@adidahiya adidahiya merged commit 8403bf2 into develop Jan 4, 2022
@adidahiya adidahiya deleted the syu/dont-flag-import-export-strings branch January 4, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants