Skip to content

Commit

Permalink
[core] fix(NumericInput): don't apply textbox role (#5420)
Browse files Browse the repository at this point in the history
  • Loading branch information
bvandercar-vt authored Jul 11, 2022
1 parent bf4c8be commit 90e46a6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/core/src/components/forms/numericInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -422,14 +422,13 @@ export class NumericInput extends AbstractPureComponent2<HTMLInputProps & Numeri
private renderInput() {
const inputGroupHtmlProps = removeNonHTMLProps(this.props, NON_HTML_PROPS, true);
const valueAsNumber = this.getCurrentValueAsNumber();
const hasSpinButtons = this.props.buttonPosition !== undefined && this.props.buttonPosition !== "none";

return (
<InputGroup
asyncControl={this.props.asyncControl}
autoComplete="off"
id={this.numericInputId}
role={hasSpinButtons ? "spinbutton" : "textbox"}
role={this.props.allowNumericCharactersOnly ? "spinbutton" : undefined}
{...inputGroupHtmlProps}
aria-valuemax={this.props.max}
aria-valuemin={this.props.min}
Expand Down

1 comment on commit 90e46a6

@blueprint-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[core] fix(NumericInput): don't apply textbox role (#5420)

Previews: documentation | landing | table | demo

Please sign in to comment.