[core] fix(NumericInput): don't apply textbox role #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandercar-vt
commented
Jul 8, 2022
| {...inputGroupHtmlProps} | ||
| aria-valuemax={this.props.max} | ||
| aria-valuemin={this.props.min} | ||
| aria-valuenow={valueAsNumber} |
There was a problem hiding this comment.
Realized that these are probably not needed due to the fact that the <input> already has min and max props, and a value.
There was a problem hiding this comment.
Is there any documentation for this? Would it hurt to leave them in?
There was a problem hiding this comment.
I don't think it hurts, just unneccessary
There was a problem hiding this comment.
Does the browser read min/max attributes when the input type is "text"? I feel like they could potentially be useful there... but again, I don't have specific documentation to support this idea.
There was a problem hiding this comment.
that is a very good point actually. We should probably keep these since the type is "text".
nerdstep
reviewed
Jul 8, 2022
bvandercar-vt
changed the title
bvandercar-vt
changed the title
adidahiya
approved these changes
Jul 11, 2022
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
update the
typeprop for the<input>element created in anumericInput.roleprop no longer needed due to giventype