[core,popover2] Fix heading colors in tooltips in dark mode (#4832)

Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
palantir · Aug 24, 2021 · f8a11af · f8a11af · blueprint-bot · Aug 24, 2021
1 parent fc6915d
commit f8a11af
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/core/src/components/popover/_common.scss b/packages/core/src/components/popover/_common.scss
@@ -139,6 +139,13 @@ $dark-popover-background-color: $dark-gray4 !default;
 
   .#{$ns}-popover-content {
     background: $background-color;
+  }
+
+  // Some popovers (like tooltips) invert their foreground/background colors relative
+  // to what we expect for the theme. In those cases, we need to override global typography
+  // styles to get the right colors.
+  .#{$ns}-popover-content,
+  .#{$ns}-heading {
     color: $text-color;
   }
 

diff --git a/packages/popover2/src/_common.scss b/packages/popover2/src/_common.scss
@@ -56,6 +56,13 @@ $pt-dark-tooltip2-box-shadow: $pt-dark-popover-box-shadow !default;
 
   .#{$ns}-popover2-content {
     background: $background-color;
+  }
+
+  // Some popovers (like tooltips) invert their foreground/background colors relative
+  // to what we expect for the theme. In those cases, we need to override global typography
+  // styles to get the right colors.
+  .#{$ns}-popover2-content,
+  .#{$ns}-heading {
     color: $text-color;
   }