Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core,popover2] Fix heading colors in tooltips in dark mode #4832

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

tomshen
Copy link
Contributor

@tomshen tomshen commented Aug 2, 2021

Fixes #3773

Checklist

  • Includes tests N/A
  • Update documentation N/A

Changes proposed in this pull request:

  • Uses text color to set heading color explicitly to override default header colors in dark mode tooltips
  • Fixed in both soon-to-be-deprecated Tooltip and Tooltip2

Reviewers should focus on:

  • Does this lead to any unexpected styling issues, since this changes the popover appearance mixin?
  • Should I add a "test" example for this case? i.e. adding an example to the tooltip docs that uses an header

Here is a Tooltip2 repro: https://codesandbox.io/s/blueprint-sandbox-forked-u378j

Screenshot

Before:

Screen Shot 2021-08-02 at 3 24 45 PM

After:

Screen Shot 2021-08-02 at 3 24 31 PM

@blueprint-bot
Copy link

Fix heading colors in tooltips in dark mode

Previews: documentation | landing | table

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to add here. the alternative would be to put this style in _tooltip.scss / _tooltip2.scss, but I think it makes sense to leave it here as well.

just added some code comments to make the code more clear.

packages/popover2/src/_common.scss Show resolved Hide resolved
@blueprint-bot
Copy link

Apply suggestions from code review

Previews: documentation | landing | table

@adidahiya adidahiya changed the title Fix heading colors in tooltips in dark mode [core,popover2] Fix heading colors in tooltips in dark mode Aug 24, 2021
@adidahiya adidahiya merged commit f8a11af into develop Aug 24, 2021
@adidahiya adidahiya deleted the ts/fix-tooltip-dark-heading-color branch August 24, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headings in tooltips in dark mode are unreadable
3 participants