Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Table column-header borders on ghost cells #1515

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Fix Table column-header borders on ghost cells #1515

merged 1 commit into from
Sep 1, 2017

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented Aug 30, 2017 •
edited
Loading

Fixes #1511

Changes proposed in this pull request:

  • 🐛 FIXED Table column-header ghost cells are no longer missing borders.

Reviewers should focus on:

  • Does the column-header border still look good in every case?
  • I noticed some existing style weirdness with header borders when there are 0 rows and/or 0 columns. Can address that later.

Screenshot

BEFORE
image

AFTER:
image

@cmslewis cmslewis added this to the 1.28.0 milestone Aug 30, 2017
@blueprint-bot
Copy link

Fix Table column-header borders on ghost cells

Preview: documentation | table
Coverage: core | datetime

@cmslewis cmslewis merged commit 4c6f750 into master Sep 1, 2017
@cmslewis cmslewis deleted the cl/table-column-header-borders branch September 1, 2017 20:16
@llorca llorca mentioned this pull request Sep 15, 2017
Merged
@cmslewis cmslewis mentioned this pull request Sep 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@llorca llorca Awaiting requested review from llorca

@themadcreator themadcreator Awaiting requested review from themadcreator

@gscshoyru gscshoyru Awaiting requested review from gscshoyru

Assignees
No one assigned
Labels
Domain: design P3 Package: table Type: bug
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cmslewis @blueprint-bot @adidahiya