Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v1.28.0 #1571

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Prepare release v1.28.0 #1571

merged 1 commit into from
Sep 16, 2017

Conversation

llorca
Copy link
Contributor

@llorca llorca commented Sep 15, 2017

📖 Latest docs: blueprintjs.com/docs

@blueprintjs/core 1.28.0

💎 New features

@blueprintjs/table 1.25.0

💎 New features

🐛 Bug fixes

@blueprintjs/labs 0.9.0

💎 New features

Documentation

@blueprint-bot
Copy link

Prepare release v1.28.0

Preview: documentation | table | github pages
Coverage: core | datetime

@llorca
Copy link
Contributor Author

llorca commented Sep 15, 2017

Looks like we've got another flaky test :(

@giladgray
Copy link
Contributor

@llorca flaky test? things look good to me.

edited release notes to provide context on new labs props, moved some more things to Documentation section.

need more context on Table new feature: what issue does this fix? can we describe it differently to capture the WHY?

@cmslewis
Copy link
Contributor

@giladgray done

Copy link
Contributor

@cmslewis cmslewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @llorca!

@llorca
Copy link
Contributor Author

llorca commented Sep 15, 2017

@giladgray yeah I had to manually retrigger the build. Focus stuff again https://circleci.com/gh/palantir/blueprint/3945

@tgreenwatts
Copy link
Contributor

Um given that #1515 seems to be broken again, should we remove it from the notes?

@tgreenwatts
Copy link
Contributor

Actually I take it back. It appears to work on this PR. It didn't on other recent table ones, but maybe they were just based on older code?

Copy link
Contributor

@tgreenwatts tgreenwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language review only

@llorca llorca merged commit 45c07c5 into master Sep 16, 2017
@llorca llorca deleted the release/1.28.0 branch September 16, 2017 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants