Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow edits to be rejected for EditableCell #2192

Closed
wants to merge 2 commits into from
Closed

Allow edits to be rejected for EditableCell #2192

wants to merge 2 commits into from

Commits on Mar 2, 2018

  1. Allow edits to be rejected for EditableCell 

    Currently, if I don't change the controlled value as the result of a `onConfirm`, this check prevents the original value from overriding the savedValue. This is useful in a case where input to the `EditableCell` is being validated, and if it doesn't pass validation, the value of the cell shouldn't change.
    @maclockard
    maclockard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    3afe22a View commit details
    Browse the repository at this point in the history

  2. Update test

    @maclockard
    maclockard committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    e623a89 View commit details
    Browse the repository at this point in the history