Allow edits to be rejected for EditableCell #2192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if I don't change the controlled value as the result of a `onConfirm`, this check prevents the original value from overriding the savedValue. This is useful in a case where input to the `EditableCell` is being validated, and if it doesn't pass validation, the value of the cell shouldn't change.
|
Thanks for your interest in palantir/blueprint, @maclockard! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
giladgray
suggested changes
Mar 13, 2018
| @@ -96,9 +96,7 @@ export class EditableCell extends React.Component<IEditableCellProps, IEditableC | |||
|
|
|||
| public componentWillReceiveProps(nextProps: IEditableCellProps) { | |||
| const { value } = nextProps; | |||
| if (value !== this.props.value) { | |||
There was a problem hiding this comment.
@maclockard i believe removing this check is wrong. it should instead by != null, just like EditableText does it. i'm going to close this PR and open my own with the correct change, and a refactor to the corresponding test.
thanks for suggesting this feature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Currently, if I don't change the controlled value as the result of a
onConfirm, this check prevents the original value from overriding the savedValue. This is useful in a case where input to theEditableCellis being validated, and if it doesn't pass validation, the value of the cell shouldn't change.