Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow edits to be rejected for EditableCell #2228

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Allow edits to be rejected for EditableCell #2228

merged 1 commit into from
Mar 14, 2018

Conversation

giladgray
Copy link
Contributor

(reboot of #2192, cc @maclockard)

Currently, if I don't change the controlled value as the result of a onConfirm, this check prevents the original value from overriding the savedValue. This is useful in a case where input to the EditableCell is being validated, and if it doesn't pass validation, the value of the cell shouldn't change.

In this PR, if EditableCell is controlled, then value prop will always update state fields on re-render.

@blueprint-bot
Copy link

Allow edits to be rejected for EditableCell

Preview: documentation | landing | table

@adidahiya adidahiya merged commit 0fe776f into develop Mar 14, 2018
@adidahiya adidahiya deleted the gg/editable-cell branch March 14, 2018 00:14
This was referenced Mar 21, 2018
Closed
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@themadcreator themadcreator Awaiting requested review from themadcreator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @adidahiya