Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filteredItems to queryList #2213

Conversation

k-simons
Copy link
Contributor

@k-simons k-simons commented Mar 7, 2018

Changes proposed in this pull request:

  • Add filtered items to the queryList rendered callback
  • Biggest issue without exposing it, is that if you implement itemListPredicate that changes the sortOrder, than you will be unable to use the raw items because those are un-sorted. So rendering will not match arrow-up / arrow-down
  • I don't know how to best solve this for select... if some implements a itemListPredicate that changes order for Select it will be broken. We could change the select to use filteredItems instead of items for their itemRenderer however that would limit people who want to do something with items that do not match the filter
  • @giladgray for SA

Reviewers should focus on:

Screenshot

@giladgray
Copy link
Contributor

@k-simons i'm going to pick up this feature as it's dear to my own heart, and i don't think this PR is enough to fully resolve the issue (esp given recent related PRs #2245 #2080). thanks for the submission!

@giladgray giladgray closed this Mar 15, 2018
@k-simons k-simons deleted the ksimons/addFilteredItemsToQueryList branch March 15, 2018 18:15
@k-simons k-simons restored the ksimons/addFilteredItemsToQueryList branch March 15, 2018 18:15
@k-simons k-simons deleted the ksimons/addFilteredItemsToQueryList branch March 15, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants