[select] Add query to itemRenderer props #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Select example with query text highlightingPreview: documentation | landing | table |
giladgray
approved these changes
Mar 15, 2018
| if (before.length > 0) { | ||
| tokens.push(before); | ||
| } | ||
| tokens.push(<span style={{ fontWeight: "bold" }}>{match[0]}</span>); |
There was a problem hiding this comment.
use <strong> tag instead please
There was a problem hiding this comment.
Good call. I completely forgot that <strong> was a thing. 🤦
| return tokens; | ||
| } | ||
|
|
||
| function regexEscape(text: string) { |
|
@reiv addressed my comments, will merge after build 👍 👍 |
renamesPreview: documentation | landing | table |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2239
Changes proposed in this pull request:
This PR adds
queryto the props passed toitemRenderer, making it possible to implement text highlighting. TheSelectdocs example now makes use of this.Screenshot