new HTMLSelect component #2605
Merged
new HTMLSelect component #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 15, 2018 16:02
Merge branch 'develop' of github.com:palantir/blueprint into gg/html-selectPreview: documentation | landing | table |
invliD
reviewed
Jun 20, 2018
| {this.renderSelectMenu("Minimum value", minValueIndex, MIN_VALUES, this.handleMinValueChange)} | ||
| {this.renderSelectMenu("Maximum value", maxValueIndex, MAX_VALUES, this.handleMaxValueChange)} | ||
| {this.renderSwitch("Disabled", disabled, this.toggleDisabled)} | ||
| {/* {this.renderSwitch("Read-only", showReadOnly, this.toggleReadOnly)} */} |
| disabled, | ||
| fill, | ||
| large, | ||
| // showReadOnly, |
| private toggleLeftIcon = handleBooleanChange(leftIcon => | ||
| this.setState({ leftIcon: leftIcon ? "dollar" : undefined }), | ||
| ); | ||
| // private toggleReadOnly = handleBooleanChange(readOnly => this.setState({ readOnly })); |
| max: 100, | ||
| min: 0, | ||
| minorStepSize: 0.1, | ||
| // readOnly: false, |
finish renamingPreview: documentation | landing | table |
invliD
approved these changes
Jun 20, 2018
deprecate Classes.SELECTPreview: documentation | landing | table |
Merge branch 'develop' into gg/html-selectPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2597
Changes proposed in this pull request:
HTMLSelectcomponent for<select>element.Classes.HTML_SELECTreplacesClasses.SELECT, no support for font icon.ns-selectstyles are still supported for direct CSS usage, but the constant no longer exists.