-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new HTMLSelect component #2605
new HTMLSelect component #2605
Conversation
Merge branch 'develop' of github.com:palantir/blueprint into gg/html-selectPreview: documentation | landing | table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed a bunch of renames (all the usages of the new component).
{this.renderSelectMenu("Minimum value", minValueIndex, MIN_VALUES, this.handleMinValueChange)} | ||
{this.renderSelectMenu("Maximum value", maxValueIndex, MAX_VALUES, this.handleMaxValueChange)} | ||
{this.renderSwitch("Disabled", disabled, this.toggleDisabled)} | ||
{/* {this.renderSwitch("Read-only", showReadOnly, this.toggleReadOnly)} */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
disabled, | ||
fill, | ||
large, | ||
// showReadOnly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
private toggleLeftIcon = handleBooleanChange(leftIcon => | ||
this.setState({ leftIcon: leftIcon ? "dollar" : undefined }), | ||
); | ||
// private toggleReadOnly = handleBooleanChange(readOnly => this.setState({ readOnly })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
max: 100, | ||
min: 0, | ||
minorStepSize: 0.1, | ||
// readOnly: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
finish renamingPreview: documentation | landing | table |
deprecate Classes.SELECTPreview: documentation | landing | table |
Merge branch 'develop' into gg/html-selectPreview: documentation | landing | table |
Fixes #2597
Changes proposed in this pull request:
HTMLSelect
component for<select>
element.Classes.HTML_SELECT
replacesClasses.SELECT
, no support for font icon.ns-select
styles are still supported for direct CSS usage, but the constant no longer exists.