Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] use IOptionProps instead of IHTMLOptionProps #2707

Merged
merged 3 commits into from
Jul 23, 2018
Merged

[core] use IOptionProps instead of IHTMLOptionProps #2707

merged 3 commits into from
Jul 23, 2018

Conversation

giladgray
Copy link
Contributor

  • I added IHTMLOptionProps in new HTMLSelect component #2605 without realizing we already had IOptionProps used in RadioGroup. oops!
  • this PR removes IHTMLOptionProps in favor of IOptionProps which is maybe a tiny API break but i doubt anyone actually uses the type
  • RadioGroup options prop supports optional label

@giladgray giladgray changed the title use IOptionProps instead of IHTMLOptionProps [core] use IOptionProps instead of IHTMLOptionProps Jul 20, 2018
@blueprint-bot
Copy link

RadioGroup supports optional label

Preview: documentation | landing | table

@giladgray giladgray merged commit 4f60b0a into develop Jul 23, 2018
@giladgray giladgray deleted the gg/option-props branch July 23, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

@themadcreator themadcreator Awaiting requested review from themadcreator

Assignees
No one assigned
Labels
Type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @invliD