[Popover] react-popper 1.0.0 #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
June 14, 2018 11:45
giladgray
changed the title
invliD
reviewed
Jun 20, 2018
| * The name of the HTML tag to use when rendering the popover target wrapper element (`Classes.POPOVER_WRAPPER`). | ||
| * @default "span" | ||
| */ | ||
| rootElementTag?: string; |
There was a problem hiding this comment.
why not let tooltips provide a wrapperTagName?
There was a problem hiding this comment.
i have a follow up PR to introduce IPopoverSharedProps that will resolve this.
There was a problem hiding this comment.
maybe i'll just open that now as there's a merge conflict here
themadcreator
approved these changes
Jun 20, 2018
|
opened #2617 which will reduce the diff here if merged first, so this PR is more focused on new react-popper API and not also changing props. |
add upgrade script entry for tooltipClassNamePreview: documentation | landing | table |
added 2 commits
June 20, 2018 15:26
giladgray
changed the title
invliD
approved these changes
Jun 20, 2018
revert examples changePreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2530
Changes proposed in this pull request:
react-popper@1.0.0which features a totally new API usingchildrenfunctions