IPopoverSharedProps used by Popover and Tooltip, some prop renames #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
export popoverSharedProps, fix ContextMenuPreview: documentation | landing | table |
giladgray
commented
Jun 20, 2018
| @@ -13,7 +13,8 @@ import * as Classes from "../../common/classes"; | |||
| import { Position } from "../../common/position"; | |||
| import { safeInvoke } from "../../common/utils"; | |||
| import { IOverlayLifecycleProps } from "../overlay/overlay"; | |||
| import { Popover, PopperModifiers } from "../popover/popover"; | |||
| import { Popover } from "../popover/popover"; | |||
| import { PopperModifiers } from "../popover/popoverSharedProps"; | |||
There was a problem hiding this comment.
thoughts on the best place for this symbol to live?
added 2 commits
June 20, 2018 15:03
add upgrade script entriesPreview: documentation | landing | table |
themadcreator
approved these changes
Jun 20, 2018
invliD
reviewed
Jun 20, 2018
| @@ -0,0 +1,140 @@ | |||
| /* | |||
There was a problem hiding this comment.
not sure about conventions here but this file doesn't need to be a tsx file.
| import { IOverlayableProps } from "../overlay/overlay"; | ||
|
|
||
| // re-export this symbol for library consumers | ||
| export { PopperModifiers }; |
| * The target element to which the popover content is attached. | ||
| * This can instead be provided as the first `children` element. | ||
| * The target to which the popover content is attached. This can instead be | ||
| * provided as the _first_ element in `children`. | ||
| */ | ||
| target?: string | JSX.Element; |
There was a problem hiding this comment.
Why are content and target not also shared?
There was a problem hiding this comment.
you'll notice they work differently. Tooltip does not support a target prop (passed via children) and it requires content prop.
i guess they could be unified... thoughts?
There was a problem hiding this comment.
Is there a reason for the API difference even though behavior is the same?
MGHawes
added a commit
to MGHawes/blueprint
that referenced
this pull request
Feb 10, 2019
In pr [palantir#2617](palantir#2617 the type of the `onInteraction` prop was [changed](palantir@f111cdc#diff-526f9b7061d074b106ee2b67a5dafc14L122) to no longer include the event as the second argument (added as part of [palantir#2340](palantir#2430)). However the the code still [conforms to the previous interface](https://github.com/palantir/blueprint/blob/9728e61b420eda381cedce06166a4caf6b958bc4/packages/core/src/components/popover/popover.tsx#L501). All I've done is change it back to what it was 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulling out the renames from #2609 and unifying the props interfaces between Popover and Tooltip.
Changes proposed in this pull request:
IPopoverSharedPropsfor the common Popover/Tooltip bitsrootElementTag=>wrapperTagNametargetElementTag=>targetTagNametooltipClassName=>popoverClassName