Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected the type of Popover's onInteraction prop #3348

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Corrected the type of Popover's onInteraction prop #3348

merged 1 commit into from
Feb 12, 2019

Commits on Feb 10, 2019

  1. Corrected the type of Popover's onInteraction prop 

    In pr [palantir#2617](palantir#2617 the type of the `onInteraction` prop was [changed](palantir@f111cdc#diff-526f9b7061d074b106ee2b67a5dafc14L122) to no longer include the event as the second argument (added as part of [palantir#2340](palantir#2430)). However the the code still [conforms to the previous interface](https://github.com/palantir/blueprint/blob/9728e61b420eda381cedce06166a4caf6b958bc4/packages/core/src/components/popover/popover.tsx#L501). All I've done is change it back to what it was 🙂
    @MGHawes
    MGHawes authored Feb 10, 2019
    Configuration menu
    Copy the full SHA
    3ec7c96 View commit details
    Browse the repository at this point in the history