[resources] update core sketch kit with symbols for components #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icons pull request #3933 from https://github.com/estevesd
* [core] feat(NumericInput): supply input element in onValueChange callback * small refactor, use optional chaining to invoke callback * fix lint * fix more tests * fix lint, remove describe.only
Allows users to press `DELETE` on their keyboards to delete an item from `<TagInput />`, which in turn is used by the `Select` family of components. Handling `DELETE` to remove item mimics the way `DELETE` works in a text editor, where an user can delete from the beginning of the line forward. Reaching the end of the line, in our case passing the last selected item in `<TagInput />` will stop deleting. Moving the selection to the first item and deleting from that point onwards repeatedly will delete all the selected items.
update INVALID_PROPS list used by removeNonHTMLProps() utility fn
aycai
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
I'll approve to get the changes in (and iterate on tweaks over time), but defer to @adidahiya to merge!
adidahiya
changed the title
|
thanks @terpimost! |
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Sketch elements are symbols now
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot