[core] feat(Drawer): return focus to active element after closing #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works in Chrome & FF |
|
Is some way to disable this available? We manage focus ourselves in our app, but this change prevents us from doing that, because it immediately undoes whatever we do and focuses the last |
|
@adidahiya is there any way to circumvent this? If you know one, it would really help us a lot! |
|
@slapbox no, but we can add a prop which enables this behavior, something like |
|
Wow that was crazy fast to have a PR opened! Thanks for your attention on this @adidahiya! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3592
Difficult to test because
document.activeElementdoesn't seem to update as expected in enzyme...