[core] feat(Overlay): add shouldReturnFocusOnClose prop #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] feat(Overlay): add shouldReturnFocusOnClose prop, enable by defaultPreviews: documentation | landing | table |
styu
reviewed
Sep 14, 2021
| * | ||
| * @default true | ||
| */ | ||
| shouldReturnFocusOnClose?: boolean; |
There was a problem hiding this comment.
I think it's more like a QOL improvement for anyone that relies on keyboard navigation, since the focus would previously return to body. If you were manually setting focus in onClose, that still runs at the end of this change so your custom focus behavior will still work.
There was a problem hiding this comment.
it's not a break, DrawerProps extends from OverlayableProps!
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Building on #4422 and #4620, this PR moves the
shouldReturnFocusOnClosefunctionality to theOverlaycomponent, thereby enabling it by default for Popover/Popover2, Tooltip/Tooltip2, and Dialogs. This is desirable for keyboard accessibility. Drawers still retain this behavior since they extend Overlay / OverlayableProps.Reviewers should focus on:
Screenshot