Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] feat: convert icons to FCs, wrap with forwardRef #4681

Merged
merged 6 commits into from
May 4, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Apr 27, 2021

Changes proposed in this pull request:

  • Convert <Icon> and auto-generated icon components in packages/icons/src/generated into function components
    • ⚠️ breaking change: Icon no longer has static constants on its public API; use IconSize from @blueprintjs/icons (or @blueprintjs/core, where it is re-exported) instead.
  • Wrap these components with React.forwardRef() so that they can be more easily used as children of <ResizeSensor>

Reviewers should focus on:

@blueprint-bot
Copy link

fix size constant usage, re-export in core

Previews: documentation | landing | table

@blueprint-bot
Copy link

WIP fix tess

Previews: documentation | landing | table

@adidahiya
Copy link
Contributor Author

adidahiya commented Apr 29, 2021

@blueprint-bot
Copy link

Merge remote-tracking branch 'origin/next' into ad/v4-icon-forwardRef

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix test suite

Previews: documentation | landing | table

@adidahiya adidahiya merged commit 515edf1 into next May 4, 2021
@adidahiya adidahiya deleted the ad/v4-icon-forwardRef branch May 4, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants