[v4] feat: convert icons to FCs, wrap with forwardRef #4681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
<Icon>
and auto-generated icon components in packages/icons/src/generated into function componentsIcon
no longer has static constants on its public API; useIconSize
from@blueprintjs/icons
(or@blueprintjs/core
, where it is re-exported) instead.React.forwardRef()
so that they can be more easily used as children of<ResizeSensor>
Reviewers should focus on:
Is removal ofIcon.SIZE_STANDARD
andIcon.SIZE_LARGE
constants ok?