[core] deprecate Icon, Drawer, Spinner size constant static members #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add spinner size constants |
adidahiya
changed the title
adidahiya
changed the title
deprecate spinner size constants tooPreviews: documentation | landing | table |
This was referenced Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
In conjunction with upcoming changes in v4.0 where class components are being refactored into function components (like #4681), we must remove support for static members and provide those constants as new symbols in the public API.
Deprecated:
Icon.SIZE_STANDARDIcon.SIZE_LARGEDrawer.SIZE_SMALLDrawer.SIZE_STANDARDDrawer.SIZE_LARGESpinner.SIZE_SMALLSpinner.SIZE_STANDARDSpinner.SIZE_LARGEAdded:
IconSizeDrawerSizeSpinnerSizeNot addressed in this PR:
OverflowList.ofType(),Select.ofType(), etc...