Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack-build-scripts] fix url() file paths in production CSS files #5241

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

adidahiya
Copy link
Contributor

Fixes #5236

Apparently, after #5204, our combo of css-loader + mini-css-extract-plugin + webpack was broken in production for url() paths. Simply upgrading webpack fixes the problem. See my comment in webpack-contrib/css-loader#1362 (comment).

@blueprint-bot
Copy link

upgrade webpack

Previews: documentation | landing | table | demo

@adidahiya
Copy link
Contributor Author

bug in landing app: the icon here is not loading, we're missing blueprint-icons.css:

image

@blueprint-bot
Copy link

import icons css in landing app to fix icon

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit e25331e into develop Apr 6, 2022
@adidahiya adidahiya deleted the ad/fix-css-loader branch April 6, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons font not loading, docs broken in Firefox
2 participants