Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webpack-build-scripts] fix url() file paths in production CSS files #5241

Merged
merged 3 commits into from
Apr 6, 2022
Merged

[webpack-build-scripts] fix url() file paths in production CSS files #5241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0761f8
tweak filename for asset modules
adidahiya Apr 6, 2022
1fd70e3
upgrade webpack
adidahiya Apr 6, 2022
6c309a4
import icons css in landing app to fix icon
adidahiya Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/landing-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
},
"dependencies": {
"@blueprintjs/core": "^4.1.0",
"@blueprintjs/icons": "^4.2.1",
"classnames": "^2.2",
"react": "^16.14.0",
"react-dom": "^16.14.0"
Expand All @@ -26,7 +27,7 @@
"copy-webpack-plugin": "^7.0.0",
"npm-run-all": "^4.1.5",
"raw-loader": "^4.0.2",
"webpack": "^5.21.0",
"webpack": "^5.71.0",
"webpack-dev-server": "^3.11.0"
},
"repository": {
Expand Down
1 change: 1 addition & 0 deletions packages/landing-app/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Licensed under the Apache License, Version 2.0.
*/

@import "~@blueprintjs/core/lib/css/blueprint.css";
@import "~@blueprintjs/icons/lib/css/blueprint-icons.css";
@import "~@blueprintjs/colors/lib/scss/colors";
@import "~@blueprintjs/core/src/common/variables";
@import "svgs";
Expand Down
2 changes: 1 addition & 1 deletion packages/landing-app/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = Object.assign({}, baseConfig, {
"blueprint-landing": ["./src/index.tsx", "./src/index.scss"],
},

// we override module rules since we don't want file-loader to be triggered for inline SVGs
// we override module rules since we don't want the asset modules loader to be triggered for inline SVGs
module: {
rules: baseConfig.module.rules.slice(0, 3).concat([
{
Expand Down
2 changes: 1 addition & 1 deletion packages/table-dev-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@types/lodash-es": "~4.17.3",
"copy-webpack-plugin": "^7.0.0",
"npm-run-all": "^4.1.5",
"webpack": "^5.21.0",
"webpack": "^5.71.0",
"webpack-dev-server": "^3.11.0"
},
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"react-dom": "^16.14.0",
"react-test-renderer": "^16.14.0",
"typescript": "~4.6.2",
"webpack": "^5.21.0"
"webpack": "^5.71.0"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-build-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"stream-browserify": "^3.0.0",
"style-loader": "^3.3.1",
"ts-loader": "^9.2.8",
"webpack": "^5.21.0",
"webpack": "^5.71.0",
"webpack-bundle-analyzer": "^4.5.0",
"webpack-dev-server": "^3.11.0",
"webpack-notifier": "^1.15.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-build-scripts/webpack.config.base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ module.exports = {
test: /\.(eot|ttf|woff|woff2|svg|png|gif|jpe?g)$/,
type: "asset/resource",
generator: {
filename: "assets/[hash][ext][query]",
filename: "assets/[name][ext][query][hash]",
},
},
],
Expand Down
373 changes: 188 additions & 185 deletions yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.