Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] fix(Suggest2): get root node correctly in Shadow DOM #5462

Merged
merged 2 commits into from
Jul 25, 2022
Merged

[select] fix(Suggest2): get root node correctly in Shadow DOM #5462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4115d49
fix Suggest2 to work with Shadow DOM #5461
Jul 25, 2022
306eef6
Renamed root to rootNode
Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/select/src/components/suggest/suggest2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,8 @@ export class Suggest2<T> extends AbstractPureComponent2<Suggest2Props<T>, Sugges
// Note that we defer to the next animation frame in order to get the latest document.activeElement
private handlePopoverInteraction = (nextOpenState: boolean, event?: React.SyntheticEvent<HTMLElement>) =>
this.requestAnimationFrame(() => {
const isInputFocused = this.inputElement === document.activeElement;
const rootNode = (this.inputElement?.getRootNode?.() ?? document) as DocumentOrShadowRoot & Node;
const isInputFocused = this.inputElement === rootNode.activeElement;

if (this.inputElement != null && !isInputFocused) {
// the input is no longer focused, we should close the popover
Expand Down