Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix(Suggest2): get root node correctly in Shadow DOM #5462

Merged
merged 2 commits into from
Jul 25, 2022
Merged

[select] fix(Suggest2): get root node correctly in Shadow DOM #5462

merged 2 commits into from
Jul 25, 2022

Conversation

kutensky
Copy link
Contributor

Fixes #5461

Changes proposed in this pull request:

Changed detecting is input focused by comparing with input's rootNode rather than with window

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @kutensky! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @kutensky! I think we'll have to audit other places where we use document.activeElement. it's probably worth having a shared helper function to get the active element which we can use across various components -- I'll implement that in a follow-up PR.

@adidahiya adidahiya changed the title Fix Suggest2 to work with Shadow DOM #5461 [select] fix(Suggest2): get root node correctly in Shadow DOM Jul 25, 2022
@adidahiya adidahiya merged commit b8cd791 into palantir:develop Jul 25, 2022
@kutensky
Copy link
Contributor Author

Thank you @adidahiya for such a quick response and for adding support on other components. That helps a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest2 not working with Shadow DOM
3 participants