Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use helper fn to get active DOM element #5463

Merged
merged 1 commit into from
Jul 25, 2022
Merged

chore: use helper fn to get active DOM element #5463

merged 1 commit into from
Jul 25, 2022

Conversation

adidahiya
Copy link
Contributor

Follow-up refactor after #5462

Changes proposed in this pull request:

  • Create a utility helper function in @blueprintjs/core to grab the document (or shadow root) active element
  • Use this new function across @blueprintjs/core and @blueprintjs/select components for consistent behavior in the shadow DOM

Reviewers should focus on:

No regressions, test suites should cover this behavior

Screenshot

N/A

@blueprint-bot
Copy link

chore: use helper fn to get active DOM element

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 61e0ab1 into develop Jul 25, 2022
@adidahiya adidahiya deleted the ad/shadow-dom-active-element branch July 25, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adidahiya @blueprint-bot