[core] fix(OverflowList): edge case in shouldComponentUpdate #5486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request (update):
Context:
Through some testing, I've been able to repro the problematic condition: props change on the same tick as both
state !== prevState
ANDshallowCompare(state, prevState) === true
.This means a re-render doesn't happen when it should. The original code was written to aggressively re-render (even in the case that the state doesn't change). But it failed to account for the case where: props change, state changes, but shallow compare is truthy (all in a single
shouldComponentUpdate
).Here's a log demonstrating this happen:
Note: This component is reasonable suited returning to a PureComponent in the future, but that will be a breaking change.