Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(OverflowList): edge case in shouldComponentUpdate #5486

Merged
merged 5 commits into from
Aug 22, 2022
Merged

[core] fix(OverflowList): edge case in shouldComponentUpdate #5486

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee6c0a5
Fix shouldComponentUpdate in OverflowList
braeden Aug 6, 2022
0330fd4
Merge remote-tracking branch 'origin/develop' into patch-2
adidahiya Aug 11, 2022
ab3545b
fix formatting
adidahiya Aug 11, 2022
b32cac6
Restore existing logic and add prop comparison
braeden Aug 14, 2022
75b7a93
Merge remote-tracking branch 'origin/develop' into patch-2
adidahiya Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/core/src/components/overflow-list/overflowList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,14 @@ export class OverflowList<T> extends React.Component<OverflowListProps<T>, IOver
this.repartition();
}

public shouldComponentUpdate(_nextProps: OverflowListProps<T>, nextState: IOverflowListState<T>) {
public shouldComponentUpdate(nextProps: OverflowListProps<T>, nextState: IOverflowListState<T>) {
// We want this component to always re-render, even when props haven't changed, so that
// changes in the renderers' behavior can be reflected.
// The following statement prevents re-rendering only in the case where the state changes
// identity (i.e. setState was called), but the state is still the same when
// shallow-compared to the previous state.
return !(this.state !== nextState && shallowCompareKeys(this.state, nextState));
// shallow-compared to the previous state. Original context: https://github.com/palantir/blueprint/pull/3278.
// We also ensure that we re-render if the props DO change (which isn't necessarily accounted for by other logic).
return this.props !== nextProps || !(this.state !== nextState && shallowCompareKeys(this.state, nextState));
}

public componentDidUpdate(prevProps: OverflowListProps<T>, prevState: IOverflowListState<T>) {
Expand Down